Thanks, I uploaded new patch set.
https://codereview.chromium.org/149083004/diff/1/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):
https://codereview.chromium.org/149083004/diff/1/src/a64/lithium-codegen-a64.cc#newcode5111
src/a64/lithium-codegen-a64.cc:5111: __ Tst(x0, x0);
On 2014/02/05 13:01:41, jbramley wrote:
ARM (and AArch64) processors generally prefer "Cmp(x0, 0)". (I assume
that the
condition can be either EQ or NE here.)
However, in this case, you're probably better off using
EmitCompareAndBranch
because that will use Cbz or Cbnz if possible.
Done.
https://codereview.chromium.org/149083004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
