Reviewers: Alexandre Rames,

Message:
PTAL. The frame iterator expects to see FP registers below the general registers
in the stack.

Description:
A64: Fix the order of pushing general and FP safepoint registers.

TEST=mjsunit/elements-transition

Please review this at https://codereview.chromium.org/136693017/

SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64

Affected files (+2, -2 lines):
  M src/a64/lithium-codegen-a64.h


Index: src/a64/lithium-codegen-a64.h
diff --git a/src/a64/lithium-codegen-a64.h b/src/a64/lithium-codegen-a64.h
index d07b225ac62bf01ba04c83df1b1ab9be0f8fd8b3..129fd3739dc75d4ed51b2416af94fddcd72db7de 100644
--- a/src/a64/lithium-codegen-a64.h
+++ b/src/a64/lithium-codegen-a64.h
@@ -372,8 +372,8 @@ class LCodeGen: public LCodeGenBase {
           codegen_->masm_->PushSafepointRegisters();
           break;
         case Safepoint::kWithRegistersAndDoubles:
-          codegen_->masm_->PushSafepointFPRegisters();
           codegen_->masm_->PushSafepointRegisters();
+          codegen_->masm_->PushSafepointFPRegisters();
           break;
         default:
           UNREACHABLE();
@@ -388,8 +388,8 @@ class LCodeGen: public LCodeGenBase {
           codegen_->masm_->PopSafepointRegisters();
           break;
         case Safepoint::kWithRegistersAndDoubles:
-          codegen_->masm_->PopSafepointRegisters();
           codegen_->masm_->PopSafepointFPRegisters();
+          codegen_->masm_->PopSafepointRegisters();
           break;
         default:
           UNREACHABLE();


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to