Reviewers: ulan,
https://codereview.chromium.org/154243005/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/154243005/diff/1/test/cctest/test-parsing.cc#newcode1116
test/cctest/test-parsing.cc:1116: bool assert_success,
On 2014/02/05 15:00:10, ulan wrote:
Maybe enum is better than two flags? Looks like they are encoding
three possible
cases.
Done.
Description:
Better tests for the Parser / Preparser unification.
We need a way to assert that for a given source code snippet, an error *is*
produced or *is not* produced. Otherwise we might accidentally create new
errors or start accepting code which was previously not accepted. Just
checking
that Parser and PreParser produce the same result doesn't cut it.
BUG=3126
LOG=N
[email protected]
Please review this at https://codereview.chromium.org/154243005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+290, -183 lines):
M test/cctest/test-parsing.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
