lgtm
https://codereview.chromium.org/152813005/diff/10007/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/152813005/diff/10007/src/parser.cc#newcode986
src/parser.cc:986: Handle<String> name = ParseIdentifier(false,
CHECK_OK);
I prefer enums to flags, because they are more readable, like:
ParseIdentifier(STRICT_EVAL_ARGUMENTS, CHECK_OK);
ParseIdentifier(CLASSIC_EVAL_ARGUMENTS, CHECK_OK);
but you may disagree.
https://codereview.chromium.org/152813005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
