Revision: 19118
Author: [email protected]
Date: Wed Feb 5 18:58:16 2014 UTC
Log: MIPS: Avoid embedding x86 NaN constant in code when snapshot is
created.
Due to a different NaN representation on MIPS, the canonical nan
constant embedded in generated code that comes from snapshot will differ
from
the one used on MIPS hardware.
TEST=mozilla/ecma/Array/15.4.4.2.js
BUG=
[email protected]
Review URL: https://codereview.chromium.org/150663009
Patch from Dusan Milosavljevic <[email protected]>.
http://code.google.com/p/v8/source/detail?r=19118
Modified:
/branches/bleeding_edge/src/mips/lithium-codegen-mips.cc
=======================================
--- /branches/bleeding_edge/src/mips/lithium-codegen-mips.cc Tue Feb 4
00:06:44 2014 UTC
+++ /branches/bleeding_edge/src/mips/lithium-codegen-mips.cc Wed Feb 5
18:58:16 2014 UTC
@@ -4222,8 +4222,8 @@
// Only load canonical NaN if the comparison above set the overflow.
__ bind(&is_nan);
- __ Move(double_scratch,
- FixedDoubleArray::canonical_not_the_hole_nan_as_double());
+ __ LoadRoot(at, Heap::kNanValueRootIndex);
+ __ ldc1(double_scratch, FieldMemOperand(at, HeapNumber::kValueOffset));
__ sdc1(double_scratch, MemOperand(scratch, instr->additional_index()
<<
element_size_shift));
__ Branch(&done);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
