Thanks, I uploaded new patch set.
https://codereview.chromium.org/145973022/diff/1/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):
https://codereview.chromium.org/145973022/diff/1/src/a64/lithium-codegen-a64.cc#newcode5132
src/a64/lithium-codegen-a64.cc:5132: __ JumpIfNotRoot(scratch1,
Heap::kTrueValueRootIndex, &check_false);
On 2014/02/05 18:43:23, m.m.capewell wrote:
It may be better to load both roots at once and use conditional
instructions.
Register true_root = output;
Register false_root = scratch2;
LoadTrueFalseRoots(true_root, false_root);
Cmp(scratch1, true_root);
Cset(output, eq);
Ccmp(scratch1, false_root, ZFlag, ne);
B(eq, &done);
// Fall through to check_undefined.
You can delete the Mov(output, 0) from check_undefined, if it can't be
reached
from elsewhere.
Nice! Done.
https://codereview.chromium.org/145973022/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
