https://codereview.chromium.org/153993011/diff/60001/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):
https://codereview.chromium.org/153993011/diff/60001/src/a64/lithium-codegen-a64.cc#newcode4463
src/a64/lithium-codegen-a64.cc:4463: ASSERT(!temp.is(string));
string is declared "AtStart" and temp is declared "TempRegister" so
nothing is stopping the allocator to give them the same register.
https://codereview.chromium.org/153993011/diff/60001/src/a64/lithium-codegen-a64.cc#newcode4464
src/a64/lithium-codegen-a64.cc:4464:
ASSERT(!temp.is(ToRegister(index)));
ditto.
https://codereview.chromium.org/153993011/diff/60001/src/a64/lithium-codegen-a64.cc#newcode4481
src/a64/lithium-codegen-a64.cc:4481: if (FLAG_debug_code) {
because string and index are at start, this debug code could corrupt
them.
It's a shame that debug code forces us to put more stringent constraints
on the allocator but we can revisit later if you add a todo.
https://codereview.chromium.org/153993011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
