https://codereview.chromium.org/140893009/diff/1/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/140893009/diff/1/src/a64/macro-assembler-a64.cc#newcode677
src/a64/macro-assembler-a64.cc:677: if (FLAG_optimize_for_size && count
4) {
The code below is 4 instructions long, PushMultipleTimes can handle 8
push in 4 instructions (using stp) so the break even point should be 8.
https://codereview.chromium.org/140893009/diff/1/src/a64/macro-assembler-a64.cc#newcode681
src/a64/macro-assembler-a64.cc:681: PushHelper(1, size, src, NoReg,
NoReg, NoReg);
if count is even you can push two at a time with no extra memory cost.
https://codereview.chromium.org/140893009/diff/1/src/a64/macro-assembler-a64.cc#newcode681
src/a64/macro-assembler-a64.cc:681: PushHelper(1, size, src, NoReg,
NoReg, NoReg);
4 at a time will be faster but bigger, is that what we want?
On 2014/02/06 14:53:12, ulan wrote:
Optimization: push 4 values at once (count / 4) times, and then set
count =
(count % 4) and fall through to the old code.
https://codereview.chromium.org/140893009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
