PTAL

I also added a test for deleted __proto__.


https://codereview.chromium.org/103343005/diff/1/test/mjsunit/proto-accessor.js
File test/mjsunit/proto-accessor.js (right):

https://codereview.chromium.org/103343005/diff/1/test/mjsunit/proto-accessor.js#newcode42
test/mjsunit/proto-accessor.js:42: // Check that any redefinition of the
__proto__ accessor works.
On 2014/02/06 11:53:22, rossberg wrote:
Maybe add a test case that redefines the setter to undefined and
assignment to
__proto__ throws accordingly.

Done.

https://codereview.chromium.org/103343005/diff/1/test/mjsunit/proto-accessor.js#newcode43
test/mjsunit/proto-accessor.js:43:
Object.defineProperty(Object.prototype, "__proto__", { get:function() {
On 2014/02/06 11:53:22, rossberg wrote:
Nit: weird indentation

Done.

https://codereview.chromium.org/103343005/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to