Not LGTM.
https://codereview.chromium.org/157393002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/157393002/diff/1/src/heap.cc#newcode6088
src/heap.cc:6088: ExecutionAccess access(isolate());
As discussed offline: This seems very much like a redundant lock to me.
I know the motivation is to make TSAN happy, but I have issues with
taking a lock in IterateStringRoots, especially for a field that is
_always_ a SMI.
One suggestion from my end would be to reorder the strong roots list in
a way that groups SMIs at the end so that the GC doesn't need to look at
them at all.
https://codereview.chromium.org/157393002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
