LGTM (with one more suggestion).
https://codereview.chromium.org/146983007/diff/140001/test/cctest/test-regexp.cc
File test/cctest/test-regexp.cc (right):
https://codereview.chromium.org/146983007/diff/140001/test/cctest/test-regexp.cc#newcode448
test/cctest/test-regexp.cc:448: return
CcTest::i_isolate()->unicode_cache()->IsWhiteSpace(c);
nit: Would it be possible to go directly to the v8::internal::WhiteSpace
predicate here? One less piece than can go wrong when computing the
reference value.
https://codereview.chromium.org/146983007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
