https://codereview.chromium.org/143003028/diff/40001/test/cctest/test-platform.cc
File test/cctest/test-platform.cc (right):

https://codereview.chromium.org/143003028/diff/40001/test/cctest/test-platform.cc#newcode60
test/cctest/test-platform.cc:60: ASM("mov sp, x0; str x0, %0" : "=g"
(sp_addr) : : "x0"); \
You are moving x0 into sp, not what you meant.

As a side I wouldn't use x0, use ip0. this way you don;t for the
compiler to save and restore it.

https://codereview.chromium.org/143003028/diff/40001/test/cctest/test-platform.cc#newcode99
test/cctest/test-platform.cc:99: #undef GET_STACK_POINTERS
not part of your patch but there shouldn't be an S at the end.

https://codereview.chromium.org/143003028/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to