Note: Rietveld fails to correctly diff or display string-trim-expected.txt
because it now contains weird whitespace characters. I guess you just have
to
trust me on this one :)
https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/third_party/string-trim.js
File test/mjsunit/third_party/string-trim.js (right):
https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/third_party/string-trim.js#newcode69
test/mjsunit/third_party/string-trim.js:69: // \u200B is not a
whitespace character according to Unicode 6.3.0.
On 2014/02/10 10:22:32, Michael Starzinger wrote:
Can we remove this copy of "string-trim" in the third party directory
(as it is
a very small subset of the original Webkit tests from Apple) and
instead keep
the version in the "webkit" directory.
Within the "webkit" directory, I would update the expectation file
instead of
editing the test.
Done.
https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/whitespaces.js
File test/mjsunit/whitespaces.js (right):
https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/whitespaces.js#newcode1
test/mjsunit/whitespaces.js:1: // Copyright 2014 the V8 project authors.
All rights reserved.
On 2014/02/10 09:30:01, mathiasb wrote:
Quick drive-by comment: please use the new/shorter license header for
new files.
// Copyright 2014 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that
can be
// found in the LICENSE file.
I'm not aware we started using this license header for V8.
https://codereview.chromium.org/141323007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
