A few API-related DBCs...
https://codereview.chromium.org/154283002/diff/20001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/154283002/diff/20001/include/v8.h#newcode3862
include/v8.h:3862: typedef void (*MicrotaskCallback)();
We should probably add an Isolate* parameter. Every time we didn't add
one for callbacks, we regretted it later...
https://codereview.chromium.org/154283002/diff/20001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/154283002/diff/20001/test/cctest/test-api.cc#newcode20553
test/cctest/test-api.cc:20553: void ExternalMicrotaskOne() {
Nit: static. Reduces the probability of linker clashes for cctest.
https://codereview.chromium.org/154283002/diff/20001/test/cctest/test-api.cc#newcode20554
test/cctest/test-api.cc:20554: v8::HandleScope scope(CcTest::isolate());
Calling CcTest::isolate() is a strong indicator that the callbacks
should probably get an Isolate* argument. CcTest::isolate() is an ugly
hack (basically Isolate::Current() in disguise) and already scheduled
for removal. :-)
https://codereview.chromium.org/154283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
