Reviewers: dcarney, m.m.capewell,
Message:
Dan, the ARM port uses r1 as a scratch, is this correct?
Why don't we use thunk_last_arg here?
https://codereview.chromium.org/159003003/diff/1/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/159003003/diff/1/src/a64/macro-assembler-a64.cc#newcode1343
src/a64/macro-assembler-a64.cc:1343: ASSERT(thunk_last_arg.is(x1) ||
thunk_last_arg.is(x2));
I took this assert from the ARM port, which also uses r1 as a scratch.
Description:
A64: Fix assertion in MacroAssembler::CallApiFunctionAndReturn.
Please review this at https://codereview.chromium.org/159003003/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+1, -1 lines):
M src/a64/macro-assembler-a64.cc
Index: src/a64/macro-assembler-a64.cc
diff --git a/src/a64/macro-assembler-a64.cc b/src/a64/macro-assembler-a64.cc
index
84269cf6f07b6cc21fdb20655577feb273d837fc..6713b248b27ec04553d705fb76c4249d49900709
100644
--- a/src/a64/macro-assembler-a64.cc
+++ b/src/a64/macro-assembler-a64.cc
@@ -1340,7 +1340,7 @@ void MacroAssembler::CallApiFunctionAndReturn(
next_address);
ASSERT(function_address.Is(x3));
- ASSERT(!AreAliased(function_address, thunk_last_arg, x1, x2));
+ ASSERT(thunk_last_arg.is(x1) || thunk_last_arg.is(x2));
// TODO(all): Why do we care about aliasing x2? (This function uses x1
as a
// scratch regiser.)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
