Reviewers: Rodolph Perfetta (ARM), ulan,
Description:
A64: Remove restriction for inlining functions now that the allocator can
handle
cp
BUG=none
[email protected],[email protected]
LOG=n
Please review this at https://codereview.chromium.org/159233002/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+0, -17 lines):
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
b4bca14e494709451a485f06ca62103fbaabb224..b72a743a4b5819a7063640eb35240d08779e8d87
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -7066,19 +7066,6 @@ bool
HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
return false;
}
-#if V8_TARGET_ARCH_A64
- // Target must be able to use caller's context.
- // TODO(jochen): Remove this block once A64's register allocator can
allocate
- // cp.
- CompilationInfo* outer_info = current_info();
- if (target->context() != outer_info->closure()->context() ||
- outer_info->scope()->contains_with() ||
- outer_info->scope()->num_heap_slots() > 0) {
- TraceInline(target, caller, "target requires context change");
- return false;
- }
-#endif
-
// Don't inline deeper than the maximum number of inlining levels.
HEnvironment* env = environment();
int current_level = 1;
@@ -7215,12 +7202,8 @@ bool
HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
undefined,
function_state()->inlining_kind());
-// TODO(jochen): Remove this #ifdef once A64's register allocator can
allocate
-// cp.
-#if !V8_TARGET_ARCH_A64
HConstant* context = Add<HConstant>(Handle<Context>(target->context()));
inner_env->BindContext(context);
-#endif
Add<HSimulate>(return_id);
current_block()->UpdateEnvironment(inner_env);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
