https://codereview.chromium.org/144423010/diff/1/src/hydrogen-gvn.h
File src/hydrogen-gvn.h (right):

https://codereview.chromium.org/144423010/diff/1/src/hydrogen-gvn.h#newcode39
src/hydrogen-gvn.h:39: class SideEffects V8_FINAL {
On 2014/02/10 14:50:07, Michael Starzinger wrote:
A comment that this is merely a GVNFlagSet plus "special" dynamic side
effects
and why we need that would be nice.

Done.

https://codereview.chromium.org/144423010/diff/1/src/hydrogen-gvn.h#newcode77
src/hydrogen-gvn.h:77: class SideEffectsScope V8_FINAL BASE_EMBEDDED {
Done.

Went for SideEffectsTracker, because we already have a HSideEffectsMap.

https://codereview.chromium.org/144423010/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to