On 2014/02/10 23:59:04, tfarina wrote:
Is this right/ok?
NOT LGTM.
This is working as intended. We are currently moving toward having
MayNamedAccess only called from handlified code (i.e. code where references
to
heap objects are kept via handles). The reason for that is that we want to
allow
the embedder to be able to do more complex things in the access callback,
including allocation on the V8 heap. That however could trigger GC. If the
objects referenced in the stack frames below are not via handles, and those
objects are moved by the GC, then those references become invalid. The work
on
this is not done yet, so the access callback is still restricted, but this
CL
would revert part of the progress.
https://codereview.chromium.org/159323003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
