On 2014/02/11 12:58:50, jbramley wrote:
https://codereview.chromium.org/131333011/diff/40001/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):
https://codereview.chromium.org/131333011/diff/40001/src/a64/lithium-codegen-a64.cc#newcode5496
src/a64/lithium-codegen-a64.cc:5496: : MacroAssembler::INT32);
Our convention for Lithium instructions is to leave the top word of an
int32
value undefined. This allows some minor efficiency improvements. We make
similar
assumptions elsewhere too.
Have you found a case where the top 32 bits are read? If an A64 Lithium
instruction takes an Integer32 representation, it shouldn't read the top
word.
BoundsCheck compares the X registers (and thus fails) in mjsunit/sin-cos.js
https://codereview.chromium.org/131333011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
