As discussed, I'd prefer an interface with just a Merge operation without a
Copy
operation. That way unreachable blocks only need to be handled by pretending
that they are in the initial state.
https://codereview.chromium.org/140543004/diff/1/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/140543004/diff/1/src/hydrogen-check-elimination.cc#newcode167
src/hydrogen-check-elimination.cc:167: if (pred_block->IsReachable() &&
succ->predecessors()->length() == 1) {
I think we shouldn't explicitly care about the number of predecessors,
but rather just copy information from all reachable blocks down and
merge it in the regular way. If the length of reachable predecessors is
one, it will automagically do what you expect.
https://codereview.chromium.org/140543004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
