Super cool. Please add more tests (we could add them to cctest
test-mementos.cc)
and platform ports.
https://codereview.chromium.org/132963012/diff/60001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/132963012/diff/60001/src/hydrogen.cc#newcode8241
src/hydrogen.cc:8241: if (!FLAG_allocation_site_pretenuring) {
Can we re-order this combination of cases to:
if (FLAG_pretenuring_call_new)
if (FLAG_allocation_site_pretenuring)
else
I think this improves readability.
https://codereview.chromium.org/132963012/diff/60001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):
https://codereview.chromium.org/132963012/diff/60001/src/ia32/builtins-ia32.cc#newcode139
src/ia32/builtins-ia32.cc:139: // Should never create mementos for api
functions. (true?)
probably
https://codereview.chromium.org/132963012/diff/60001/src/ia32/builtins-ia32.cc#newcode234
src/ia32/builtins-ia32.cc:234: __ bind(&do_store);
We could also undo the Memento allocation. WDYT?
https://codereview.chromium.org/132963012/diff/60001/src/type-info.cc
File src/type-info.cc (right):
https://codereview.chromium.org/132963012/diff/60001/src/type-info.cc#newcode155
src/type-info.cc:155: Handle<Object> info = GetInfo(slot);
we can do that in one line
https://codereview.chromium.org/132963012/diff/60001/src/type-info.cc#newcode161
src/type-info.cc:161: Handle<Object> info = GetInfo(slot);
we can do that in one line
https://codereview.chromium.org/132963012/diff/60001/src/type-info.cc#newcode167
src/type-info.cc:167: Handle<Object> info = GetInfo(slot);
we can do that in one line
https://codereview.chromium.org/132963012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
