Reviewers: ulan,
Description:
A64: Remove A64 special casing from DoubleToIStub
Please review this at https://codereview.chromium.org/159953002/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+2, -28 lines):
M src/code-stubs.h
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index
8276bf61ba0c8a102cc38005825b313bf44a1d19..0a90dbbe13eb49e1b86b1ac9222ede851e355ec2
100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1874,9 +1874,6 @@ class DoubleToIStub : public PlatformCodeStub {
int offset,
bool is_truncating,
bool skip_fastpath = false) : bit_field_(0) {
-#if V8_TARGET_ARCH_A64
- // TODO(jbramley): Make A64's Register type compatible with the normal
code,
- // so we don't need this special case.
bit_field_ = SourceRegisterBits::encode(source.code()) |
DestinationRegisterBits::encode(destination.code()) |
OffsetBits::encode(offset) |
@@ -1884,37 +1881,14 @@ class DoubleToIStub : public PlatformCodeStub {
SkipFastPathBits::encode(skip_fastpath) |
SSEBits::encode(CpuFeatures::IsSafeForSnapshot(SSE2) ?
CpuFeatures::IsSafeForSnapshot(SSE3) ? 2 : 1 : 0);
-#else
- bit_field_ = SourceRegisterBits::encode(source.code_) |
- DestinationRegisterBits::encode(destination.code_) |
- OffsetBits::encode(offset) |
- IsTruncatingBits::encode(is_truncating) |
- SkipFastPathBits::encode(skip_fastpath) |
- SSEBits::encode(CpuFeatures::IsSafeForSnapshot(SSE2) ?
- CpuFeatures::IsSafeForSnapshot(SSE3) ? 2 : 1 : 0);
-#endif
}
Register source() {
-#if V8_TARGET_ARCH_A64
- // TODO(jbramley): Make A64's Register type compatible with the normal
code,
- // so we don't need this special case.
- return Register::XRegFromCode(SourceRegisterBits::decode(bit_field_));
-#else
- Register result = { SourceRegisterBits::decode(bit_field_) };
- return result;
-#endif
+ return Register::from_code(SourceRegisterBits::decode(bit_field_));
}
Register destination() {
-#if V8_TARGET_ARCH_A64
- // TODO(jbramley): Make A64's Register type compatible with the normal
code,
- // so we don't need this special case.
- return
Register::XRegFromCode(DestinationRegisterBits::decode(bit_field_));
-#else
- Register result = { DestinationRegisterBits::decode(bit_field_) };
- return result;
-#endif
+ return
Register::from_code(DestinationRegisterBits::decode(bit_field_));
}
bool is_truncating() {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
