Revision: 19296
Author:   [email protected]
Date:     Tue Feb 11 18:23:45 2014 UTC
Log:      A64: Remove A64 special casing from DoubleToIStub

[email protected]

Review URL: https://codereview.chromium.org/159953002
http://code.google.com/p/v8/source/detail?r=19296

Modified:
 /branches/experimental/a64/src/code-stubs.h

=======================================
--- /branches/experimental/a64/src/code-stubs.h Tue Feb 11 17:36:50 2014 UTC
+++ /branches/experimental/a64/src/code-stubs.h Tue Feb 11 18:23:45 2014 UTC
@@ -1874,9 +1874,6 @@
                 int offset,
                 bool is_truncating,
                 bool skip_fastpath = false) : bit_field_(0) {
-#if V8_TARGET_ARCH_A64
- // TODO(jbramley): Make A64's Register type compatible with the normal code,
-    // so we don't need this special case.
     bit_field_ = SourceRegisterBits::encode(source.code()) |
       DestinationRegisterBits::encode(destination.code()) |
       OffsetBits::encode(offset) |
@@ -1884,37 +1881,14 @@
       SkipFastPathBits::encode(skip_fastpath) |
       SSEBits::encode(CpuFeatures::IsSafeForSnapshot(SSE2) ?
                       CpuFeatures::IsSafeForSnapshot(SSE3) ? 2 : 1 : 0);
-#else
-    bit_field_ = SourceRegisterBits::encode(source.code_) |
-      DestinationRegisterBits::encode(destination.code_) |
-      OffsetBits::encode(offset) |
-      IsTruncatingBits::encode(is_truncating) |
-      SkipFastPathBits::encode(skip_fastpath) |
-      SSEBits::encode(CpuFeatures::IsSafeForSnapshot(SSE2) ?
-                      CpuFeatures::IsSafeForSnapshot(SSE3) ? 2 : 1 : 0);
-#endif
   }

   Register source() {
-#if V8_TARGET_ARCH_A64
- // TODO(jbramley): Make A64's Register type compatible with the normal code,
-    // so we don't need this special case.
-    return Register::XRegFromCode(SourceRegisterBits::decode(bit_field_));
-#else
-    Register result = { SourceRegisterBits::decode(bit_field_) };
-    return result;
-#endif
+    return Register::from_code(SourceRegisterBits::decode(bit_field_));
   }

   Register destination() {
-#if V8_TARGET_ARCH_A64
- // TODO(jbramley): Make A64's Register type compatible with the normal code,
-    // so we don't need this special case.
- return Register::XRegFromCode(DestinationRegisterBits::decode(bit_field_));
-#else
-    Register result = { DestinationRegisterBits::decode(bit_field_) };
-    return result;
-#endif
+ return Register::from_code(DestinationRegisterBits::decode(bit_field_));
   }

   bool is_truncating() {

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to