Reviewers: rmcilroy,
Message:
PTAL
Description:
A64: Fix ArrayConstructorStub and remove GCC 4.8 specific flags.
BUG=
Please review this at https://codereview.chromium.org/137753011/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+4, -11 lines):
M build/toolchain.gypi
M src/a64/code-stubs-a64.cc
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index
3ed8c6587fc44e3e5981eca0c917f8018ac22b0b..c2a33007334a829ccab0d3bb9992628f40e091dc
100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -520,10 +520,7 @@
'cflags':
[ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
'-Wnon-virtual-dtor', '-Woverloaded-virtual',
'<(wno_array_bounds)',
- # Hide some GCC 4.8 warnings:
- # TODO(jbramley): Only enable these on GCC 4.8.
- '-Wno-unused-local-typedefs',
- '-Wno-maybe-uninitialized' ],
+ ],
'conditions': [
['v8_optimized_debug==0', {
'cflags!': [
@@ -625,10 +622,6 @@
'-fdata-sections',
'-ffunction-sections',
'<(wno_array_bounds)',
- # Hide some GCC 4.8 warnings:
- # TODO(jbramley): Only enable these on GCC 4.8.
- '-Wno-unused-local-typedefs',
- '-Wno-maybe-uninitialized',
],
'conditions': [
[ 'gcc_version==44 and clang==0', {
Index: src/a64/code-stubs-a64.cc
diff --git a/src/a64/code-stubs-a64.cc b/src/a64/code-stubs-a64.cc
index
f77700dac229a79f1d483a8a914c0e2deb86f545..269b97f41c17fe8d4107bceb1fbaf832977aabeb
100644
--- a/src/a64/code-stubs-a64.cc
+++ b/src/a64/code-stubs-a64.cc
@@ -5429,10 +5429,10 @@ void ArrayConstructorStub::Generate(MacroAssembler*
masm) {
// In feedback_vector, we expect either undefined or a valid fixed
array.
Label okay_here;
- Handle<Map> cell_map = masm->isolate()->factory()->cell_map();
+ Handle<Map> fixed_array_map =
masm->isolate()->factory()->fixed_array_map();
__ JumpIfRoot(feedback_vector, Heap::kUndefinedValueRootIndex,
&okay_here);
- __ Ldr(x10, FieldMemOperand(feedback_vector, Cell::kMapOffset));
- __ Cmp(x10, Operand(cell_map));
+ __ Ldr(x10, FieldMemOperand(feedback_vector, FixedArray::kMapOffset));
+ __ Cmp(x10, Operand(fixed_array_map));
__ Assert(eq, kExpectedFixedArrayInFeedbackVector);
// slot_index should be a smi if we don't have undefined in
feedback_vector.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
