Reviewers: jochen,
Message:
PTAL
Description:
A64: Remove debug tracing.
BUG=
Please review this at https://codereview.chromium.org/160303002/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+5, -15 lines):
M src/compiler.cc
M test/mjsunit/div-mod.js
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index
2459c697b924f644bb5456c5950cd7b516d41cc6..b773880b8c76f348bacf6aa90196b1a5d9fb2394
100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -314,15 +314,6 @@ OptimizedCompileJob::Status
OptimizedCompileJob::CreateGraph() {
// shared function object.
ASSERT(info()->shared_info()->code()->kind() == Code::FUNCTION);
- if (FLAG_trace_opt) {
- // TODO(jbramley): This was added to help analyse the behaviour of
- // Crankshaft for the A64 Crankshaft port. It should eventually be
deleted.
- Handle<JSFunction> function = info()->closure();
- PrintF("Attempting optimization of ");
- function->PrintName();
- PrintF(" / %" V8PRIxPTR "\n", reinterpret_cast<intptr_t>(*function));
- }
-
// We should never arrive here if optimization has been disabled on the
// shared function info.
ASSERT(!info()->shared_info()->optimization_disabled());
Index: test/mjsunit/div-mod.js
diff --git a/test/mjsunit/div-mod.js b/test/mjsunit/div-mod.js
index
9f71ec3545d8280b25448da040ab2420263f4a25..08cee8cdd143078f117e3aa5fb2b1530ec2c2e39
100644
--- a/test/mjsunit/div-mod.js
+++ b/test/mjsunit/div-mod.js
@@ -127,14 +127,13 @@ function compute_mod(dividend, divisor) {
NaN,
0,
- // TODO(all): due to a bug in fmod(), modulos involving denormals
- // return the wrong result for glibc <= 2.16. Restore these cases when
- // development machines have been upgraded.
+ // Due to a bug in fmod(), modulos involving denormals
+ // return the wrong result for glibc <= 2.16.
// Details: http://sourceware.org/bugzilla/show_bug.cgi?id=14048
- // Number.MIN_VALUE,
- // 3 * Number.MIN_VALUE,
- // max_denormal,
+ Number.MIN_VALUE,
+ 3 * Number.MIN_VALUE,
+ max_denormal,
min_normal,
repeating_decimal,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
