Reviewers: jochen, ulan,
Description:
A64: Remove two TODOs that will not be done.
- For the LDP/STP TODO: The arguments need dereferencing, so using LDP/STP
would
require some additional checks.
- For the constant pools TODO: Unless we need to, there is no benefit from
trying to generate constant pools more often, as it would likely only
pollute
the I-cache.
Please review this at https://codereview.chromium.org/151363004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -5 lines):
M src/a64/assembler-a64.cc
M src/a64/builtins-a64.cc
Index: src/a64/assembler-a64.cc
diff --git a/src/a64/assembler-a64.cc b/src/a64/assembler-a64.cc
index
f2cc1077bb1d459f222733938cf1ca021306624b..c06fbe900bf19cd8b57cdfbdd68039d541d68aee
100644
--- a/src/a64/assembler-a64.cc
+++ b/src/a64/assembler-a64.cc
@@ -2354,9 +2354,6 @@ void Assembler::BlockConstPoolFor(int instructions) {
}
-// TODO(all): We are never trying to emit constant pools after
unconditional
-// branches, because we only call it from Assembler::Emit() (or manually).
-// We should try to enable that.
void Assembler::CheckConstPool(bool force_emit, bool require_jump) {
// Some short sequence of instruction mustn't be broken up by constant
pool
// emission, such sequences are protected by calls to BlockConstPoolFor
and
Index: src/a64/builtins-a64.cc
diff --git a/src/a64/builtins-a64.cc b/src/a64/builtins-a64.cc
index
ee6654ab758fd22b31c29bfbb686bf4c3795693e..34156b31621db9a192668da50eaf3e8b3bcd7ae7
100644
--- a/src/a64/builtins-a64.cc
+++ b/src/a64/builtins-a64.cc
@@ -684,8 +684,6 @@ static void
Generate_JSEntryTrampolineHelper(MacroAssembler* masm,
// Compute the copy end address.
__ Add(x10, argv, Operand(argc, LSL, kPointerSizeLog2));
- // TODO(all): This can potentially be optimized with ldp/stp to speed
up
- // arguments passing from C++ to JS.
__ B(&entry);
__ Bind(&loop);
__ Ldr(x11, MemOperand(argv, kPointerSize, PostIndex));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
