On 2014/02/12 15:33:19, Hannes Payer wrote:
https://codereview.chromium.org/150413009/diff/30001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/150413009/diff/30001/src/spaces.h#newcode685
src/spaces.h:685: AtomicWord prev_chunk_;
On 2014/02/12 14:06:39, jarin wrote:
> Perhaps it would be better to add a comment describing the type of the
> AtomicWords (i.e., MemoryChunk*).
>
> Should not next_chunk_ and prev_chunk_ be private?

Done.

lgtm.

thanks, ship it!

https://codereview.chromium.org/150413009/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to