Revision: 19346
Author: [email protected]
Date: Thu Feb 13 09:36:20 2014 UTC
Log: Do not internalize in TryConvertKey.
[email protected]
Review URL: https://codereview.chromium.org/163213002
http://code.google.com/p/v8/source/detail?r=19346
Modified:
/branches/bleeding_edge/src/ic.cc
=======================================
--- /branches/bleeding_edge/src/ic.cc Thu Feb 13 08:43:53 2014 UTC
+++ /branches/bleeding_edge/src/ic.cc Thu Feb 13 09:36:20 2014 UTC
@@ -983,8 +983,6 @@
key = Handle<Smi>(Smi::FromInt(int_value), isolate);
}
}
- } else if (key->IsString()) {
- key = isolate->factory()->InternalizeString(Handle<String>::cast(key));
} else if (key->IsUndefined()) {
key = isolate->factory()->undefined_string();
}
@@ -1063,8 +1061,8 @@
MaybeObject* maybe_object = NULL;
Handle<Code> stub = generic_stub();
- // Check for values that can be converted into an internalized string
directly
- // or is representable as a smi.
+ // Check for non-string values that can be converted into an
+ // internalized string directly or is representable as a smi.
key = TryConvertKey(key, isolate());
if (key->IsInternalizedString()) {
@@ -1660,8 +1658,8 @@
return *result;
}
- // Check for values that can be converted into an internalized string
directly
- // or is representable as a smi.
+ // Check for non-string values that can be converted into an
+ // internalized string directly or is representable as a smi.
key = TryConvertKey(key, isolate());
MaybeObject* maybe_object = NULL;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
