lgtm
In addition to what we discussed offline:
https://codereview.chromium.org/135213007/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/135213007/diff/1/src/preparser.h#newcode116
src/preparser.h:116: typename Traits::FunctionStateParamType*
extra_param = NULL);
Maybe rename Traits::FunctionStateParamType to just Traits::Zone and
extra_param to zone. This will make at least one case (parser) readable.
For preparser it doesn't make sense, but it will be clear from the void
typedef.
https://codereview.chromium.org/135213007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
