lgtm
https://codereview.chromium.org/163623002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/163623002/diff/1/src/hydrogen.cc#newcode9616
src/hydrogen.cc:9616: if (push_sim_result == NO_PUSH_BEFORE_SIMULATE) {
nit: I'd find it slightly more readable to swap the condition; then you
can also drop the ASSERT (it's clear enough what's going on):
if (push_sim_result == PUSH_BEFORE_SIMULATE) {
Push(result);
AddSimulate(bailout_id, REMOVABLE_SIMULATE);
Drop(1);
} else {
AddSimulate(bailout_id, REMOVABLE_SIMULATE);
}
https://codereview.chromium.org/163623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
