Thanks for the review. Landed.
https://codereview.chromium.org/140683011/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/140683011/diff/1/src/hydrogen-instructions.h#newcode1170
src/hydrogen-instructions.h:1170: // TODO(vegorov): what we really want
to track here is a combination of
On 2014/02/12 17:32:06, Yang wrote:
Is this still a TODO?
Done.
https://codereview.chromium.org/140683011/diff/1/src/hydrogen-instructions.h#newcode1250
src/hydrogen-instructions.h:1250: const intptr_t result = (val <<
kPositionShift) | kPositionTag;
Good catch!
I was using 31 bits originally to avoid loosing any, but then I was
cleaning up some code and ended up with 32 bits in HSourcePosition. I
will fix it.
https://codereview.chromium.org/140683011/diff/1/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/140683011/diff/1/src/hydrogen.h#newcode2091
src/hydrogen.h:2091: function_state_ = state;
On 2014/02/12 17:32:06, Yang wrote:
stray edit?
Done.
https://codereview.chromium.org/140683011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
