Revision: 19362
Author:   [email protected]
Date:     Thu Feb 13 16:53:18 2014 UTC
Log:      Fix A64 build: unwrap HSourcePosition into int before recording.

Remove unused position_ field in the LChunkBuilder.

[email protected]
BUG=

Review URL: https://codereview.chromium.org/163913003
http://code.google.com/p/v8/source/detail?r=19362

Modified:
 /branches/bleeding_edge/src/a64/lithium-a64.cc
 /branches/bleeding_edge/src/a64/lithium-a64.h
 /branches/bleeding_edge/src/a64/lithium-codegen-a64.cc

=======================================
--- /branches/bleeding_edge/src/a64/lithium-a64.cc Wed Feb 12 09:19:30 2014 UTC +++ /branches/bleeding_edge/src/a64/lithium-a64.cc Thu Feb 13 16:53:18 2014 UTC
@@ -671,7 +671,6 @@
 void LChunkBuilder::VisitInstruction(HInstruction* current) {
   HInstruction* old_current = current_instruction_;
   current_instruction_ = current;
-  if (current->has_position()) position_ = current->position();

   LInstruction* instr = NULL;
   if (current->CanReplaceWithDummyUses()) {
=======================================
--- /branches/bleeding_edge/src/a64/lithium-a64.h Wed Feb 12 09:19:30 2014 UTC +++ /branches/bleeding_edge/src/a64/lithium-a64.h Thu Feb 13 16:53:18 2014 UTC
@@ -2827,7 +2827,6 @@
         current_instruction_(NULL),
         current_block_(NULL),
         allocator_(allocator),
-        position_(RelocInfo::kNoPosition),
         instruction_pending_deoptimization_environment_(NULL),
         pending_deoptimization_ast_id_(BailoutId::None()) { }

@@ -2956,7 +2955,6 @@
   HInstruction* current_instruction_;
   HBasicBlock* current_block_;
   LAllocator* allocator_;
-  int position_;
   LInstruction* instruction_pending_deoptimization_environment_;
   BailoutId pending_deoptimization_ast_id_;

=======================================
--- /branches/bleeding_edge/src/a64/lithium-codegen-a64.cc Thu Feb 13 15:49:01 2014 UTC +++ /branches/bleeding_edge/src/a64/lithium-codegen-a64.cc Thu Feb 13 16:53:18 2014 UTC
@@ -782,7 +782,8 @@

       HValue* value =
           instructions_->at(code->instruction_index())->hydrogen_value();
-      RecordAndWritePosition(value->position());
+      RecordAndWritePosition(
+ chunk()->graph()->SourcePositionToScriptPosition(value->position()));

       Comment(";;; <@%d,#%d> "
               "-------------------- Deferred %s --------------------",
@@ -917,6 +918,7 @@
       translations_.CreateByteArray(isolate()->factory());
   data->SetTranslationByteArray(*translations);
   data->SetInlinedFunctionCount(Smi::FromInt(inlined_function_count_));
+  data->SetOptimizationId(Smi::FromInt(info_->optimization_id()));

   Handle<FixedArray> literals =
       factory()->NewFixedArray(deoptimization_literals_.length(), TENURED);

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to