Reviewers: Hannes Payer,
Description:
Add flags for write barrier elimination and local allocation folding.
[email protected]
Please review this at https://codereview.chromium.org/166163003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -0 lines):
M src/flag-definitions.h
M src/hydrogen-instructions.h
M src/hydrogen-instructions.cc
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
393e2a65652bee86859249ff887c8cbf68cda997..72a617dc9d4fecd1c96699ab3054d3efa71e5c96
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -251,6 +251,8 @@ DEFINE_bool(use_canonicalizing, true, "use hydrogen
instruction canonicalizing")
DEFINE_bool(use_inlining, true, "use function inlining")
DEFINE_bool(use_escape_analysis, false, "use hydrogen escape analysis")
DEFINE_bool(use_allocation_folding, true, "use allocation folding")
+DEFINE_bool(use_local_allocation_folding, false, "only fold in basic
blocks")
+DEFINE_bool(use_write_barrier_elimination, true, "eliminate write
barriers")
DEFINE_int(max_inlining_levels, 5, "maximum number of inlining levels")
DEFINE_int(max_inlined_source_size, 600,
"maximum source size in bytes considered for a single inlining")
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index
889ebfd05fc6f47a4cb835269ab29ddbd686f02e..af093d9aa5488ebc541ecdc6c2ed9f14d433ed01
100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -3384,6 +3384,15 @@ void HAllocate::HandleSideEffectDominator(GVNFlag
side_effect,
return;
}
+ // Check whether we are folding within the same block for local folding.
+ if (FLAG_use_local_allocation_folding && dominator->block() != block()) {
+ if (FLAG_trace_allocation_folding) {
+ PrintF("#%d (%s) cannot fold into #%d (%s), crosses basic blocks\n",
+ id(), Mnemonic(), dominator->id(), dominator->Mnemonic());
+ }
+ return;
+ }
+
HAllocate* dominator_allocate = HAllocate::cast(dominator);
HValue* dominator_size = dominator_allocate->size();
HValue* current_size = size();
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
93e49082bf7c4cf02b7d0104f42edd8add011968..95bcd0c4750ffa1a249f1f357b3b31d786e7fd7f
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -6428,6 +6428,7 @@ class HStoreNamedField V8_FINAL : public
HTemplateInstruction<3> {
virtual void HandleSideEffectDominator(GVNFlag side_effect,
HValue* dominator) V8_OVERRIDE {
ASSERT(side_effect == kChangesNewSpacePromotion);
+ if (!FLAG_use_write_barrier_elimination) return;
new_space_dominator_ = dominator;
}
virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
