lgtm with a nit:
https://codereview.chromium.org/166653005/diff/110001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/166653005/diff/110001/src/x64/lithium-codegen-x64.cc#newcode2784
src/x64/lithium-codegen-x64.cc:2784: if (FLAG_debug_code) {
I think it is better to use #ifdef DEBUG as we did for check in
StoreNamedField.
https://codereview.chromium.org/166653005/diff/110001/src/x64/lithium-codegen-x64.cc#newcode3034
src/x64/lithium-codegen-x64.cc:3034: if (FLAG_debug_code) {
Same as above.
https://codereview.chromium.org/166653005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
