I have one last question!
https://codereview.chromium.org/160423002/diff/340001/test/cctest/test-assembler-a64.cc
File test/cctest/test-assembler-a64.cc (left):
https://codereview.chromium.org/160423002/diff/340001/test/cctest/test-assembler-a64.cc#oldcode9377
test/cctest/test-assembler-a64.cc:9377: TEST(ecma_262_to_int32) {
Does this test not work any more? I don't think I've ever tried to
create a stub in one of these tests.
Also, can you check that RunAllTruncationTests covers all of these cases
please? There is little intersection between the two sets of values, but
the values here were designed to exercise the A64 implementation. All of
these conversions are specified by ECMA so they should be valid for all
platforms.
https://codereview.chromium.org/160423002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
