Reviewers: ulan,

Description:
A64: Make simulator compiler with optdebug

For some reason, the compiler cannot deduce the array bounds in opt
debug mode. An explicit check makes it happy.

BUG=none
[email protected]
LOG=n

Please review this at https://codereview.chromium.org/169473003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+2, -4 lines):
  M src/a64/simulator-a64.cc


Index: src/a64/simulator-a64.cc
diff --git a/src/a64/simulator-a64.cc b/src/a64/simulator-a64.cc
index c89830996456b947b936d96ad34efad5d1befa85..640fcd6c9664bfe9b194279a7bda144bbebf9d1f 100644
--- a/src/a64/simulator-a64.cc
+++ b/src/a64/simulator-a64.cc
@@ -2738,10 +2738,8 @@ bool Simulator::PrintValue(const char* desc) {
   }

   int i = CodeFromName(desc);
-  if (i == -1) {
-    return false;
-  }
-  ASSERT(i >= 0);
+  STATIC_ASSERT(kNumberOfRegisters == kNumberOfFPRegisters);
+ if (i < 0 || static_cast<unsigned>(i) >= kNumberOfFPRegisters) return false;

   if (desc[0] == 'v') {
     PrintF("%s %s:%s 0x%016" PRIx64 "%s (%s%s:%s %g%s %s:%s %g%s)\n",


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to