LGTM with nits.
https://codereview.chromium.org/169363002/diff/50001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/169363002/diff/50001/src/objects.cc#newcode8038
src/objects.cc:8038: Name* key = desc->GetKey(descriptor);
Can we substitute away this variable? I *think* it is safe to use a
naked pointer here, but it's far from obvious. Moving it closer to its
use makes things clearer and safer.
https://codereview.chromium.org/169363002/diff/50001/src/objects.cc#newcode8064
src/objects.cc:8064: Name* key = other->GetKey(descriptor);
Same here, even though we have 2 uses.
https://codereview.chromium.org/169363002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
