LGTM with nit.
https://codereview.chromium.org/166793002/diff/100001/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):
https://codereview.chromium.org/166793002/diff/100001/src/a64/lithium-codegen-a64.cc#newcode2622
src/a64/lithium-codegen-a64.cc:2622: __ Add(result, result, dividend);
Please merge the last Mov and the Add.
https://codereview.chromium.org/166793002/diff/100001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/166793002/diff/100001/src/arm/lithium-codegen-arm.cc#newcode1382
src/arm/lithium-codegen-arm.cc:1382: __ add(result, result, dividend);
Same as for a64.
https://codereview.chromium.org/166793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
