Reviewers: dcarney,
Message:
PTAL
Description:
Remove unnecessary checks in CompileStoreInterceptor on a64.
BUG=
Please review this at https://codereview.chromium.org/163963003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -16 lines):
M src/a64/stub-cache-a64.cc
Index: src/a64/stub-cache-a64.cc
diff --git a/src/a64/stub-cache-a64.cc b/src/a64/stub-cache-a64.cc
index
517556b801358e15924e3f0aea7ffb1f8cee69e1..3cf2a29cc33c63c9c32d31e07771d6ea59d54c38
100644
--- a/src/a64/stub-cache-a64.cc
+++ b/src/a64/stub-cache-a64.cc
@@ -1293,18 +1293,6 @@ Handle<Code>
StoreStubCompiler::CompileStoreInterceptor(
ASM_LOCATION("StoreStubCompiler::CompileStoreInterceptor");
- // Check that the map of the object hasn't changed.
- __ CheckMap(receiver(), scratch1(), Handle<Map>(object->map()), &miss,
- DO_SMI_CHECK);
-
- // Perform global security token check if needed.
- if (object->IsJSGlobalProxy()) {
- __ CheckAccessGlobalProxy(receiver(), scratch1(), &miss);
- }
-
- // Stub is never generated for non-global objects that require access
checks.
- ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
-
__ Push(receiver(), this->name(), value());
// Do tail-call to the runtime system.
@@ -1312,10 +1300,6 @@ Handle<Code>
StoreStubCompiler::CompileStoreInterceptor(
ExternalReference(IC_Utility(IC::kStoreInterceptorProperty),
isolate());
__ TailCallExternalReference(store_ic_property, 3, 1);
- // Handle store cache miss.
- __ Bind(&miss);
- TailCallBuiltin(masm(), MissBuiltin(kind()));
-
// Return the generated code.
return GetCode(kind(), Code::FAST, name);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
