After having a closer look at the code and some discussions with Benedikt,
we
decided that the master plan should probably be slightly different: After
landing the CL with the fix, we should split both div-i and mod-i into 2
parts,
one for a constant right argument and one for a non-constant one. The
constant
version can consistently handle power-of-2 cases and replace division by a
multiplication with the reciprocal.
Hopefully we can merge MathFloorOfDiv into this, it is only slightly
different.
The current code as really a total mess with tons of duplicated code and
probably various hidden bugs (which have already been fixed at other
places).
Furthermore it misses quite a few optimization opportunities, not only on
ARM,
but on all platforms. :-/
https://codereview.chromium.org/164183002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
