https://codereview.chromium.org/163183004/diff/150001/tools/push-to-trunk/merge_to_branch.py
File tools/push-to-trunk/merge_to_branch.py (right):
https://codereview.chromium.org/163183004/diff/150001/tools/push-to-trunk/merge_to_branch.py#newcode103
tools/push-to-trunk/merge_to_branch.py:103: for revision in
self._options.args:
How about building full_revision_list from args first and then iterating
over
full_revision_list to find port_revision?
https://codereview.chromium.org/163183004/diff/150001/tools/push-to-trunk/merge_to_branch.py#newcode118
tools/push-to-trunk/merge_to_branch.py:118:
full_revision_list.append(svn_revision)
See comment below, appending here can be avoided.
https://codereview.chromium.org/163183004/diff/150001/tools/push-to-trunk/merge_to_branch.py#newcode135
tools/push-to-trunk/merge_to_branch.py:135: full_revision_list =
self._options.args
It seems cleaner to append port_revision_list on 'y' instead of
restoring full_revision_list on 'n'. Also it doesn't remove duplicates
anymore.
https://codereview.chromium.org/163183004/diff/150001/tools/push-to-trunk/merge_to_branch.py#newcode186
tools/push-to-trunk/merge_to_branch.py:186:
self._state["patch_commit_hashes"] = patch_commit_hashes
Why isn't it persisted and restored like other state variables?
https://codereview.chromium.org/163183004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
