lgtm. A small nit a and a question.
https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (left):
https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profiler.cc#oldcode2432
test/cctest/test-heap-profiler.cc:2432: int retainers =
GetRetainersCount(snapshot, backing_store);
Looks like coverage for GetRetainersCount is gone?
https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profiler.cc#newcode2418
test/cctest/test-heap-profiler.cc:2418: uint8_t* data =
static_cast<uint8_t*>(ab_contents.Data());
Nit: why uint8_t and not void*? Saves you a cast.
https://codereview.chromium.org/170253008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
