Reviewers: palfia, kilvadyb, dusmil, gergely.kis,
Message:
PTAL. On my test board, I got back to baseline performance on this test.
Description:
MIPS: Fix performance regression on sunspider string-unpack-code.
Regression surfaced with r19009, but latent error was present since
r17767.
BUG=
Please review this at https://codereview.chromium.org/171793005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -2 lines):
M src/mips/stub-cache-mips.cc
Index: src/mips/stub-cache-mips.cc
diff --git a/src/mips/stub-cache-mips.cc b/src/mips/stub-cache-mips.cc
index
7e3c801399c50243144061f1bbffda6a0e45339f..0a90c607b2d231d709d73e34ca1b98ac3a98b1e7
100644
--- a/src/mips/stub-cache-mips.cc
+++ b/src/mips/stub-cache-mips.cc
@@ -1443,7 +1443,7 @@ Handle<Code>
BaseLoadStoreStubCompiler::CompilePolymorphicIC(
Label number_case;
Label* smi_target = IncludesNumberType(types) ? &number_case : &miss;
- __ JumpIfSmi(receiver(), smi_target);
+ __ JumpIfSmi(receiver(), smi_target); // Scratch reg 'at' left at 0 if
Smi.
Register map_reg = scratch1();
@@ -1455,12 +1455,13 @@ Handle<Code>
BaseLoadStoreStubCompiler::CompilePolymorphicIC(
Handle<Map> map = IC::TypeToMap(*type, isolate());
if (!map->is_deprecated()) {
number_of_handled_maps++;
+ __ Subu(at, map_reg, Operand(map));
if (type->Is(HeapType::Number())) {
ASSERT(!number_case.is_unused());
__ bind(&number_case);
}
__ Jump(handlers->at(current), RelocInfo::CODE_TARGET,
- eq, map_reg, Operand(map));
+ eq, at, Operand(zero_reg));
}
}
ASSERT(number_of_handled_maps != 0);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
