Revision: 19473
Author: [email protected]
Date: Wed Feb 19 09:38:45 2014 UTC
Log: A64: Remove early_exit unused mechanism in CompareMap.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/169733003
http://code.google.com/p/v8/source/detail?r=19473
Modified:
/branches/bleeding_edge/src/a64/lithium-codegen-a64.cc
/branches/bleeding_edge/src/a64/macro-assembler-a64.cc
/branches/bleeding_edge/src/a64/macro-assembler-a64.h
=======================================
--- /branches/bleeding_edge/src/a64/lithium-codegen-a64.cc Tue Feb 18
17:42:49 2014 UTC
+++ /branches/bleeding_edge/src/a64/lithium-codegen-a64.cc Wed Feb 19
09:38:45 2014 UTC
@@ -2109,7 +2109,7 @@
Label success;
for (int i = 0; i < map_set.size(); i++) {
Handle<Map> map = map_set.at(i).handle();
- __ CompareMap(map_reg, map, &success);
+ __ CompareMap(map_reg, map);
__ B(eq, &success);
}
=======================================
--- /branches/bleeding_edge/src/a64/macro-assembler-a64.cc Tue Feb 18
13:51:24 2014 UTC
+++ /branches/bleeding_edge/src/a64/macro-assembler-a64.cc Wed Feb 19
09:38:45 2014 UTC
@@ -3441,18 +3441,14 @@
void MacroAssembler::CompareMap(Register obj,
Register scratch,
- Handle<Map> map,
- Label* early_success) {
- // TODO(jbramley): The early_success label isn't used. Remove it.
+ Handle<Map> map) {
Ldr(scratch, FieldMemOperand(obj, HeapObject::kMapOffset));
- CompareMap(scratch, map, early_success);
+ CompareMap(scratch, map);
}
void MacroAssembler::CompareMap(Register obj_map,
- Handle<Map> map,
- Label* early_success) {
- // TODO(jbramley): The early_success label isn't used. Remove it.
+ Handle<Map> map) {
Cmp(obj_map, Operand(map));
}
@@ -3466,10 +3462,8 @@
JumpIfSmi(obj, fail);
}
- Label success;
- CompareMap(obj, scratch, map, &success);
+ CompareMap(obj, scratch, map);
B(ne, fail);
- Bind(&success);
}
@@ -3493,10 +3487,9 @@
if (smi_check_type == DO_SMI_CHECK) {
JumpIfSmi(obj_map, fail);
}
- Label success;
- CompareMap(obj_map, map, &success);
+
+ CompareMap(obj_map, map);
B(ne, fail);
- Bind(&success);
}
=======================================
--- /branches/bleeding_edge/src/a64/macro-assembler-a64.h Tue Feb 18
13:15:32 2014 UTC
+++ /branches/bleeding_edge/src/a64/macro-assembler-a64.h Wed Feb 19
09:38:45 2014 UTC
@@ -1307,20 +1307,16 @@
Register type_reg,
InstanceType type);
- // Compare an object's map with the specified map and its transitioned
- // elements maps if mode is ALLOW_ELEMENT_TRANSITION_MAPS. Condition
flags are
- // set with result of map compare. If multiple map compares are
required, the
- // compare sequences branches to early_success.
+ // Compare an object's map with the specified map. Condition flags are
set
+ // with result of map compare.
void CompareMap(Register obj,
Register scratch,
- Handle<Map> map,
- Label* early_success = NULL);
+ Handle<Map> map);
// As above, but the map of the object is already loaded into the
register
// which is preserved by the code generated.
void CompareMap(Register obj_map,
- Handle<Map> map,
- Label* early_success = NULL);
+ Handle<Map> map);
// Check if the map of an object is equal to a specified map and branch
to
// label if not. Skip the smi check if not required (object is known to
be a
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
