On 2014/02/19 13:04:30, ulan wrote:
This regressed several tests in debug snapshot=off build.
Sorry!
For example:
./out/a64.debug/d8 --test --nobreak-on-abort --nodead-code-elimination
--nofold-constants --enable-slow-asserts --debug-code --verify-heap
--allow-natives-syntax --nodead-code-elimination --nofold-constants
--nouse-gvn
./test/mjsunit/mjsunit.js ./test/mjsunit/regress/regress-2612.js
#
# Fatal error in ../src/a64/assembler-a64.cc, line 563
# CHECK((num_pending_reloc_info_ == 0) || (pc_offset() <
(first_const_pool_use_
+ kMaxDistToPool))) failed
#
That happens because that test calls PushMultipleTimes with a huge 'count'.
PushHelper has an InstructionAccurateScope, which prevents the constant pool
from being emitted, but there is no unrestricted region because
InstructionAccurateScope doesn't call CheckConstPool itself. (PushHelper
doesn't
actually need InstructionAccurateScope, but I'm working on a fix for that
independently. We should still fix InstructionAccurateScope.)
I can fix InstructionAccurateScope quickly.
There also bunch of cctests failing with:
#
# Fatal error in ../src/a64/assembler-a64.cc, line 2342
# external code buffer is too small
#
That's trickier to fix, but I'll investigate. I might have to temporarily
disable the AssertStackConsistency in PrepareForPush, since that's what
triggered this problem the first time around (with snapshots enabled). I'm
currently running the cctests with snapshots=off but I haven't hit a failing
test yet.
https://codereview.chromium.org/170623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
