https://codereview.chromium.org/169843002/diff/230001/tools/push-to-trunk/auto_roll.py
File tools/push-to-trunk/auto_roll.py (right):
https://codereview.chromium.org/169843002/diff/230001/tools/push-to-trunk/auto_roll.py#newcode108
tools/push-to-trunk/auto_roll.py:108: push_pattern = "^Version
[[:digit:]]*\.[[:digit:]]*\.[[:digit:]]* (based"
On 2014/02/19 12:44:49, Jakob wrote:
Same s/*/+/ comment here... this looks like a candidate for
refactoring. Let's
add a helper to class Step, roughly:
def FindLastTrunkPush():
push_pattern = "^Version [[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+
(based"
args = "log -1 --format=%%H --grep=\"%s\" svn/trunk" % push_pattern
return self.Git(args).strip()
Extract method: Done. Regarding +: see the other comment.
https://codereview.chromium.org/169843002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
