On 2014/02/19 13:24:08, Sven Panne wrote:
https://codereview.chromium.org/172133003/diff/110001/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):
https://codereview.chromium.org/172133003/diff/110001/src/a64/lithium-codegen-a64.cc#newcode3858
src/a64/lithium-codegen-a64.cc:3858: __ Clz(result, input);
Hmmm, can we mix W and X registers in a single instruction? The intention
seems
to be "count in 32bits and silently expand the result to 64bit", no clue
if
this
is possible.
https://codereview.chromium.org/172133003/diff/110001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/172133003/diff/110001/src/ia32/lithium-codegen-ia32.cc#newcode4134
src/ia32/lithium-codegen-ia32.cc:4134: __ Set(result, Immediate(63)); //
64^31
== 32
63^31=32
https://codereview.chromium.org/172133003/diff/110001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/172133003/diff/110001/src/x64/lithium-codegen-x64.cc#newcode3739
src/x64/lithium-codegen-x64.cc:3739: __ Set(result, 63); // 64^31 == 32
63^31=32
My bad. The debug build actually gets assertion failures for A64. Revised
version uploaded.
https://codereview.chromium.org/172133003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
