lgtm with a comment
https://codereview.chromium.org/166903012/diff/1/tools/push-to-trunk/common_includes.py
File tools/push-to-trunk/common_includes.py (right):
https://codereview.chromium.org/166903012/diff/1/tools/push-to-trunk/common_includes.py#newcode463
tools/push-to-trunk/common_includes.py:463: except:
This will catch all exceptions. Is that intended? Maybe there is a git
specific exception you can use here.
https://codereview.chromium.org/166903012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
