On 2014/02/19 21:12:44, Hannes Payer wrote:
On 2014/02/18 21:39:46, jochen wrote:
> On 2014/02/18 17:21:09, Hannes Payer wrote:
> > What about changing the test expectations? I think we already did that
when
we
> > added sweeper threads.
>
> starting the thread adds about 40MB, the current expectation is
something
like
> 4MB. If we increase the expectation to ~50MB, the test becomes kinda
pointless
Well, the platform threads are not really part of the isolate, they are
part
of
the platform so I understand that we do not want to account for the memory
overhead in the test.
40MB is a lot. What is our story for non Chrome embedders actually? Are we
going
to provide a lightweight platform thread library? How does starting of the
platform threads effect the runtime of our tests?
10MB per thread is about as lightweight as threads get.
Note that this is a zero-sum change here anyway - if the platform threads
are
spun up, we don't spin up the sweeper threads. They're exactly the same
size.
https://codereview.chromium.org/170483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
