Reviewers: ulan,
Message:
ulan, ptal
Description:
Unify (Pre)Parser::ParseObjectLiteral and add tests.
Notes:
- The regexp in the ParseObjectLiteralComment was wrong, made it less wrong
(
it's still wrong since trailing commas are not required / allowed).
- Change in logic: In case we have "get somekeyword() { }",
the "somekeyword"
was not logged as a symbol by PreParser and not expected in the preparser
data
by Parser. This is unnecessary complication; in other contexts where
keywords
are allowed as identifiers, they are logged as symbols (see
ParseIdentifierName).
BUG=v8:3126
LOG=N
[email protected]
Please review this at https://codereview.chromium.org/173273006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+149, -37 lines):
M src/parser.cc
M src/preparser.cc
M test/cctest/test-parsing.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
